From: Victor Stinner <vstinner@python.org>
Date: Wed, 20 Mar 2024 23:06:24 +0000 (+0100)
Subject: gh-116869: Enable -Werror in test_cext for Free Threading (#117106)
X-Git-Tag: v3.13.0a6~208
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f4cc77d494ee0e10ed84ce369f0910c70a2f6d44;p=thirdparty%2FPython%2Fcpython.git

gh-116869: Enable -Werror in test_cext for Free Threading (#117106)

Check for warnings, but don't enable the compiler flag
-Werror=declaration-after-statement.
---

diff --git a/Lib/test/test_cext/setup.py b/Lib/test/test_cext/setup.py
index 1a4ec26f9985..ccad3fa62ad0 100644
--- a/Lib/test/test_cext/setup.py
+++ b/Lib/test/test_cext/setup.py
@@ -11,17 +11,19 @@ from setuptools import setup, Extension
 
 
 SOURCE = 'extension.c'
-if not support.MS_WINDOWS and not support.Py_GIL_DISABLED:
+if not support.MS_WINDOWS:
     # C compiler flags for GCC and clang
     CFLAGS = [
         # The purpose of test_cext extension is to check that building a C
         # extension using the Python C API does not emit C compiler warnings.
         '-Werror',
-
-        # gh-116869: The Python C API must be compatible with building
-        # with the -Werror=declaration-after-statement compiler flag.
-        '-Werror=declaration-after-statement',
     ]
+    if not support.Py_GIL_DISABLED:
+        CFLAGS.append(
+            # gh-116869: The Python C API must be compatible with building
+            # with the -Werror=declaration-after-statement compiler flag.
+            '-Werror=declaration-after-statement',
+        )
 else:
     # Don't pass any compiler flag to MSVC
     CFLAGS = []