From: Andreas Schneider <asn@samba.org>
Date: Thu, 2 Nov 2017 20:49:43 +0000 (+0100)
Subject: s3:passdb: Fix a memory leak in secrets_fetch_or_upgrade_domain_info()
X-Git-Tag: tevent-0.9.34~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f56ce215c7fc957f5e24f015343366239c7fe900;p=thirdparty%2Fsamba.git

s3:passdb: Fix a memory leak in secrets_fetch_or_upgrade_domain_info()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Mon Nov 13 14:05:46 CET 2017 on sn-devel-144
---

diff --git a/source3/passdb/machine_account_secrets.c b/source3/passdb/machine_account_secrets.c
index 75f31cb04e2..40511f96a8b 100644
--- a/source3/passdb/machine_account_secrets.c
+++ b/source3/passdb/machine_account_secrets.c
@@ -1476,6 +1476,7 @@ NTSTATUS secrets_fetch_or_upgrade_domain_info(const char *domain,
 		DBG_ERR("secrets_domain_info_password_create(pw) failed "
 			"for %s - %s\n", domain, nt_errstr(status));
 		dbwrap_transaction_cancel(db);
+		SAFE_FREE(old_pw);
 		TALLOC_FREE(frame);
 		return status;
 	}