From: Tilghman Lesher <tilghman@meg.abyt.es>
Date: Tue, 30 Oct 2007 22:15:28 +0000 (+0000)
Subject: If no '?' is found in the arguments, don't attempt to continue.
X-Git-Tag: 1.6.0-beta1~3^2~1065
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f59581126507620190394e8dacfe1bdb1ef9b791;p=thirdparty%2Fasterisk.git

If no '?' is found in the arguments, don't attempt to continue.
Reported by: blitzrage
Fixed by: tilghman
Closes issue #11111


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@87724 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/apps/app_exec.c b/apps/app_exec.c
index 73d534a1b6..12b91a4882 100644
--- a/apps/app_exec.c
+++ b/apps/app_exec.c
@@ -166,6 +166,11 @@ static int execif_exec(struct ast_channel *chan, void *data)
 	char *parse = ast_strdupa(data);
 
 	AST_NONSTANDARD_APP_ARGS(expr, parse, '?');
+	if (ast_strlen_zero(expr.remainder)) {
+		ast_log(LOG_ERROR, "Usage: ExecIf(<cond>?<appiftrue>(<args>):<appiffalse>(<args))\n");
+		return -1;
+	}
+
 	AST_NONSTANDARD_APP_ARGS(apps, expr.remainder, ':');
 
 	if (apps.t && (truedata = strchr(apps.t, '('))) {