From: Nick Mathewson Date: Thu, 27 Jul 2017 20:11:58 +0000 (-0400) Subject: Note that threadpool_queue_work...() can't actually return NULL X-Git-Tag: tor-0.3.1.5-alpha~16^2^2~1 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f5a852de91110c4db367946e848656b45a078f39;p=thirdparty%2Ftor.git Note that threadpool_queue_work...() can't actually return NULL --- diff --git a/src/common/workqueue.c b/src/common/workqueue.c index f44f566d21..d1303ee0e3 100644 --- a/src/common/workqueue.c +++ b/src/common/workqueue.c @@ -360,7 +360,8 @@ workerthread_new(int32_t lower_priority_chance, * function's responsibility to free the work object. * * On success, return a workqueue_entry_t object that can be passed to - * workqueue_entry_cancel(). On failure, return NULL. + * workqueue_entry_cancel(). On failure, return NULL. (Failure is not + * currently possible, but callers should check anyway.) * * Items are executed in a loose priority order -- each thread will usually * take from the queued work with the highest prioirity, but will occasionally