From: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Date: Mon, 30 Aug 2021 17:49:34 +0000 (+0200)
Subject: bpo-43398: Add test for defect connection factories (GH-27966)
X-Git-Tag: v3.11.0a1~302
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f62763d26755260c31c717fb396550e00eb6b2a0;p=thirdparty%2FPython%2Fcpython.git

bpo-43398: Add test for defect connection factories (GH-27966)
---

diff --git a/Lib/sqlite3/test/factory.py b/Lib/sqlite3/test/factory.py
index 7faa9ac8c1fc..9e7a7e28c6ed 100644
--- a/Lib/sqlite3/test/factory.py
+++ b/Lib/sqlite3/test/factory.py
@@ -24,9 +24,6 @@ import unittest
 import sqlite3 as sqlite
 from collections.abc import Sequence
 
-class MyConnection(sqlite.Connection):
-    def __init__(self, *args, **kwargs):
-        sqlite.Connection.__init__(self, *args, **kwargs)
 
 def dict_factory(cursor, row):
     d = {}
@@ -40,14 +37,19 @@ class MyCursor(sqlite.Cursor):
         self.row_factory = dict_factory
 
 class ConnectionFactoryTests(unittest.TestCase):
-    def setUp(self):
-        self.con = sqlite.connect(":memory:", factory=MyConnection)
-
-    def tearDown(self):
-        self.con.close()
+    def test_connection_factories(self):
+        class DefectFactory(sqlite.Connection):
+            def __init__(self, *args, **kwargs):
+                return None
+        class OkFactory(sqlite.Connection):
+            def __init__(self, *args, **kwargs):
+                sqlite.Connection.__init__(self, *args, **kwargs)
+
+        for factory in DefectFactory, OkFactory:
+            with self.subTest(factory=factory):
+                con = sqlite.connect(":memory:", factory=factory)
+                self.assertIsInstance(con, factory)
 
-    def test_is_instance(self):
-        self.assertIsInstance(self.con, MyConnection)
 
 class CursorFactoryTests(unittest.TestCase):
     def setUp(self):