From: Chengwei Yang <chengwei.yang@intel.com>
Date: Fri, 6 Sep 2013 03:26:44 +0000 (+0800)
Subject: Fix pass wrong type of argument to function
X-Git-Tag: dbus-1.7.6~55
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f658047ec8453dc7a7ba5ebe66bf113050915da0;p=thirdparty%2Fdbus.git

Fix pass wrong type of argument to function

The last argument of function _dbus_transport_new_for_socket() is
declared as const DBusString *. However, it is passed as a bool value.
Although the value of FALSE equals NULL in fact, this is an incorrect
use of function.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69165
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
---

diff --git a/dbus/dbus-server-socket.c b/dbus/dbus-server-socket.c
index ae4b602e8..808476470 100644
--- a/dbus/dbus-server-socket.c
+++ b/dbus/dbus-server-socket.c
@@ -101,7 +101,7 @@ handle_new_client_fd_and_unlock (DBusServer *server,
       return TRUE;
     }
 
-  transport = _dbus_transport_new_for_socket (client_fd, &server->guid_hex, FALSE);
+  transport = _dbus_transport_new_for_socket (client_fd, &server->guid_hex, NULL);
   if (transport == NULL)
     {
       _dbus_close_socket (client_fd, NULL);