From: Christian Hesse <mail@eworm.de>
Date: Mon, 23 Nov 2015 18:15:25 +0000 (+0100)
Subject: virt: add comment about order in virtualization detection
X-Git-Tag: v229~283^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f6875b0a630cdcc6bb312f130ae92fc8becfb231;p=thirdparty%2Fsystemd.git

virt: add comment about order in virtualization detection
---

diff --git a/src/basic/virt.c b/src/basic/virt.c
index a271c87333e..b82680a54bf 100644
--- a/src/basic/virt.c
+++ b/src/basic/virt.c
@@ -269,6 +269,13 @@ int detect_vm(void) {
         if (cached_found >= 0)
                 return cached_found;
 
+        /* We have to use the correct order here:
+         * Some virtualization technologies do use KVM hypervisor but are
+         * expected to be detected as something else. So detect DMI first.
+         *
+         * An example is Virtualbox since version 5.0, which uses KVM backend.
+         * Detection via DMI works corretly, the CPU ID would find KVM
+         * only. */
         r = detect_vm_dmi();
         if (r < 0)
                 return r;