From: Jim Meyering Date: Thu, 16 Jun 2005 21:37:37 +0000 (+0000) Subject: Don't embed `this'-style quotes in format strings. X-Git-Tag: CPPI-1_12~578 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f696c57a8ee46a7df82f860275b88fb329740e69;p=thirdparty%2Fcoreutils.git Don't embed `this'-style quotes in format strings. Include "quote.h". Rather than this: error (..., "...`%s'...", arg); do this: error (..., "...%s...", quote (arg)); --- diff --git a/src/expr.c b/src/expr.c index a0982f85d7..1c245b832c 100644 --- a/src/expr.c +++ b/src/expr.c @@ -37,6 +37,7 @@ #include "long-options.h" #include "error.h" #include "inttostr.h" +#include "quote.h" #include "quotearg.h" #include "strnumcmp.h" #include "xstrtol.h" @@ -423,7 +424,7 @@ docolon (VALUE *sv, VALUE *pv) error (0, 0, _("\ warning: unportable BRE: `%s': using `^' as the first character\n\ of the basic regular expression is not portable; it is being ignored"), - pv->u.s); + quote (pv->u.s)); } len = strlen (pv->u.s);