From: Victor Stinner <vstinner@python.org>
Date: Mon, 18 Mar 2024 13:54:45 +0000 (+0100)
Subject: Revert "gh-96844: Improve error message of list.remove (gh-106455)" (#116956)
X-Git-Tag: v3.13.0a6~263
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f6cdc6b4a191b75027de342aa8b5d344fb31313e;p=thirdparty%2FPython%2Fcpython.git

Revert "gh-96844: Improve error message of list.remove (gh-106455)" (#116956)

This reverts commit 217f47d6e5e56bca78b8556e910cd00890f6f84a.
---

diff --git a/Doc/library/doctest.rst b/Doc/library/doctest.rst
index 1bfcd69f72df..835a3a768061 100644
--- a/Doc/library/doctest.rst
+++ b/Doc/library/doctest.rst
@@ -430,10 +430,10 @@ Simple example::
    >>> [1, 2, 3].remove(42)
    Traceback (most recent call last):
      File "<stdin>", line 1, in <module>
-   ValueError: 42 is not in list
+   ValueError: list.remove(x): x not in list
 
-That doctest succeeds if :exc:`ValueError` is raised, with the ``42 is not in list``
-detail as shown.
+That doctest succeeds if :exc:`ValueError` is raised, with the ``list.remove(x):
+x not in list`` detail as shown.
 
 The expected output for an exception must start with a traceback header, which
 may be either of the following two lines, indented the same as the first line of
diff --git a/Lib/test/test_xml_etree.py b/Lib/test/test_xml_etree.py
index 14df482ba6c2..3f01a79cc05e 100644
--- a/Lib/test/test_xml_etree.py
+++ b/Lib/test/test_xml_etree.py
@@ -329,7 +329,7 @@ class ElementTreeTest(unittest.TestCase):
         self.serialize_check(element, '<tag key="value" />') # 5
         with self.assertRaises(ValueError) as cm:
             element.remove(subelement)
-        self.assertIn('not in list', str(cm.exception))
+        self.assertEqual(str(cm.exception), 'list.remove(x): x not in list')
         self.serialize_check(element, '<tag key="value" />') # 6
         element[0:0] = [subelement, subelement, subelement]
         self.serialize_check(element[1], '<subtag />')
diff --git a/Objects/listobject.c b/Objects/listobject.c
index 6f919ce02b3c..096043bb3d3c 100644
--- a/Objects/listobject.c
+++ b/Objects/listobject.c
@@ -3194,7 +3194,7 @@ list_remove_impl(PyListObject *self, PyObject *value)
         else if (cmp < 0)
             return NULL;
     }
-    PyErr_Format(PyExc_ValueError, "%R is not in list", value);
+    PyErr_SetString(PyExc_ValueError, "list.remove(x): x not in list");
     return NULL;
 }