From: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Date: Tue, 24 Dec 2024 03:34:56 +0000 (+0900)
Subject: firmware: imx-scu: fix OF node leak in .probe()
X-Git-Tag: v5.10.236~162
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f6db1a83aec76f9d68ed62088fce947696c0edc1;p=thirdparty%2Fkernel%2Fstable.git

firmware: imx-scu: fix OF node leak in .probe()

[ Upstream commit fbf10b86f6057cf79300720da4ea4b77e6708b0d ]

imx_scu_probe() calls of_parse_phandle_with_args(), but does not
release the OF node reference obtained by it. Add a of_node_put() call
after done with the node.

Fixes: f25a066d1a07 ("firmware: imx-scu: Support one TX and one RX")
Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/drivers/firmware/imx/imx-scu.c b/drivers/firmware/imx/imx-scu.c
index dca79caccd01c..fa25c082109ac 100644
--- a/drivers/firmware/imx/imx-scu.c
+++ b/drivers/firmware/imx/imx-scu.c
@@ -279,6 +279,7 @@ static int imx_scu_probe(struct platform_device *pdev)
 		return ret;
 
 	sc_ipc->fast_ipc = of_device_is_compatible(args.np, "fsl,imx8-mu-scu");
+	of_node_put(args.np);
 
 	num_channel = sc_ipc->fast_ipc ? 2 : SCU_MU_CHAN_NUM;
 	for (i = 0; i < num_channel; i++) {