From: Volker Lendecke <vlendec@samba.org>
Date: Sat, 30 Apr 2005 13:21:13 +0000 (+0000)
Subject: r6536: Jeremy, did you actually test this part of revision 801? I just tested that
X-Git-Tag: samba-misc-tags/initial-v3-0-unstable~4900
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f6e27305101ab0c7e04e55b4905e91c19b31f9ef;p=thirdparty%2Fsamba.git

r6536: Jeremy, did you actually test this part of revision 801? I just tested that
 Windows 2003 returns "4 (Local Group)" for

rpcclient -c 'lookupnames "System Operators"'

Before #ifdef'ing that out again I would like to see a sniff how you get a "5"
(WKN_GRP) out of lsa_lookupnames.

Volker
---

diff --git a/source/rpc_server/srv_lsa_nt.c b/source/rpc_server/srv_lsa_nt.c
index 5e949f0e63f..4d79589e59d 100644
--- a/source/rpc_server/srv_lsa_nt.c
+++ b/source/rpc_server/srv_lsa_nt.c
@@ -173,12 +173,10 @@ static void init_lsa_rid2s(DOM_R_REF *ref, DOM_RID2 *rid2,
 			status = lookup_name(dom_name, user, &sid, &name_type);
 		}
 
-#if 0 /* This is not true. */
 		if (name_type == SID_NAME_WKN_GRP) {
 			/* BUILTIN aliases are still aliases :-) */
 			name_type = SID_NAME_ALIAS;
 		}
-#endif
 
 		DEBUG(5, ("init_lsa_rid2s: %s\n", status ? "found" : 
 			  "not found"));