From: Amitay Isaacs Date: Sat, 3 Mar 2018 15:09:33 +0000 (+1100) Subject: ctdb-ib: Avoid fall through case statements X-Git-Tag: talloc-2.1.12~237 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f70164d65958956c689f0e2ee3bdd0c7634c146f;p=thirdparty%2Fsamba.git ctdb-ib: Avoid fall through case statements This is clearly unintended. Noticed with gcc 7.3. Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke --- diff --git a/ctdb/ib/ibwrapper.c b/ctdb/ib/ibwrapper.c index f7334b528e7..5ca3b946f00 100644 --- a/ctdb/ib/ibwrapper.c +++ b/ctdb/ib/ibwrapper.c @@ -503,10 +503,13 @@ static void ibw_event_handler_cm(struct tevent_context *ev, case RDMA_CM_EVENT_ADDR_ERROR: sprintf(ibw_lasterr, "RDMA_CM_EVENT_ADDR_ERROR, error %d\n", event->status); + goto error; case RDMA_CM_EVENT_ROUTE_ERROR: sprintf(ibw_lasterr, "RDMA_CM_EVENT_ROUTE_ERROR, error %d\n", event->status); + goto error; case RDMA_CM_EVENT_CONNECT_ERROR: sprintf(ibw_lasterr, "RDMA_CM_EVENT_CONNECT_ERROR, error %d\n", event->status); + goto error; case RDMA_CM_EVENT_UNREACHABLE: sprintf(ibw_lasterr, "RDMA_CM_EVENT_UNREACHABLE, error %d\n", event->status); goto error;