From: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Date: Thu, 17 Jun 2021 16:14:30 +0000 (+0100)
Subject: bpo-43024: improve signature (in help, etc) for functions taking sent… (GH-24331)
X-Git-Tag: v3.11.0a1~841
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f73377d57c5272390de63cccc3c292c44689310a;p=thirdparty%2FPython%2Fcpython.git

bpo-43024: improve signature (in help, etc) for functions taking sent… (GH-24331)



…inel defaults
---

diff --git a/Lib/test/test_traceback.py b/Lib/test/test_traceback.py
index e9df1ce9c79c..78b2851d3849 100644
--- a/Lib/test/test_traceback.py
+++ b/Lib/test/test_traceback.py
@@ -4,6 +4,7 @@ from collections import namedtuple
 from io import StringIO
 import linecache
 import sys
+import inspect
 import unittest
 import re
 from test import support
@@ -255,6 +256,21 @@ class TracebackCases(unittest.TestCase):
         self.assertEqual(
             traceback.format_exception_only(None, None), [NONE_EXC_STRING])
 
+    def test_signatures(self):
+        self.assertEqual(
+            str(inspect.signature(traceback.print_exception)),
+            ('(exc, /, value=<implicit>, tb=<implicit>, '
+             'limit=None, file=None, chain=True)'))
+
+        self.assertEqual(
+            str(inspect.signature(traceback.format_exception)),
+            ('(exc, /, value=<implicit>, tb=<implicit>, limit=None, '
+             'chain=True)'))
+
+        self.assertEqual(
+            str(inspect.signature(traceback.format_exception_only)),
+            '(exc, /, value=<implicit>)')
+
 
 class TracebackFormatTests(unittest.TestCase):
 
diff --git a/Lib/traceback.py b/Lib/traceback.py
index e19745df6def..b4c7641addec 100644
--- a/Lib/traceback.py
+++ b/Lib/traceback.py
@@ -84,8 +84,11 @@ _context_message = (
     "another exception occurred:\n\n")
 
 
-_sentinel = object()
+class _Sentinel:
+    def __repr__(self):
+        return "<implicit>"
 
+_sentinel = _Sentinel()
 
 def _parse_value_tb(exc, value, tb):
     if (value is _sentinel) != (tb is _sentinel):
diff --git a/Misc/NEWS.d/next/Library/2021-01-25-21-24-55.bpo-43024.vAUrIi.rst b/Misc/NEWS.d/next/Library/2021-01-25-21-24-55.bpo-43024.vAUrIi.rst
new file mode 100644
index 000000000000..56596ce3c2a9
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2021-01-25-21-24-55.bpo-43024.vAUrIi.rst
@@ -0,0 +1 @@
+Improve the help signature of :func:`traceback.print_exception`, :func:`traceback.format_exception` and :func:`traceback.format_exception_only`.