From: Guido van Rossum <guido@python.org>
Date: Fri, 19 Jun 1998 04:28:10 +0000 (+0000)
Subject: There was an error check in a loop in PythonCmd which called
X-Git-Tag: v1.5.2a1~451
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f766e23f63589032a64366be4b9d0549f0ed1b3d;p=thirdparty%2FPython%2Fcpython.git

There was an error check in a loop in PythonCmd which called
PythonCmd_Error() but failed to return.  The error wasn't very likely
(only when we run out of memory) but since the check is there we might
as well return the error.  (I think that Barry introduced this buglet
when he added error checks everywhere.)
---

diff --git a/Modules/_tkinter.c b/Modules/_tkinter.c
index 6d096a04c79f..bf7501ee9943 100644
--- a/Modules/_tkinter.c
+++ b/Modules/_tkinter.c
@@ -1202,7 +1202,7 @@ PythonCmd(clientData, interp, argc, argv)
 		PyObject *s = PyString_FromString(argv[i + 1]);
 		if (!s || PyTuple_SetItem(arg, i, s)) {
 			Py_DECREF(arg);
-			PythonCmd_Error(interp);
+			return PythonCmd_Error(interp);
 		}
 	}
 	res = PyEval_CallObject(func, arg);