From: Naveen Kumar Chaudhary <naveen.osdev@gmail.com>
Date: Fri, 10 Jul 2026 15:22:15 +0000 (+0530)
Subject: cmd: mbr: return false instead of NULL from bool found_key()
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f7b525a8bc5396b84cf873bdfa5750731de398e9;p=thirdparty%2Fu-boot.git

cmd: mbr: return false instead of NULL from bool found_key()

found_key() is declared to return bool but returns NULL when strdup()
fails. NULL is a pointer constant; while it happens to convert to
zero (i.e. false) it is a type mismatch that trips stricter
compilers/static analysers.

Return false to match the declared return type.

Signed-off-by: Naveen Kumar Chaudhary <naveen.osdev@gmail.com>
---

diff --git a/cmd/mbr.c b/cmd/mbr.c
index 7fe6c9e103a..b282b68d50e 100644
--- a/cmd/mbr.c
+++ b/cmd/mbr.c
@@ -73,7 +73,7 @@ static bool found_key(const char *str, const char *key)
 
 	strcopy = strdup(str);
 	if (!strcopy)
-		return NULL;
+		return false;
 
 	s = strcopy;
 	while (s) {