From: Michal 'vorner' Vaner Date: Mon, 28 Jan 2013 12:51:45 +0000 (+0100) Subject: [2439] Add missing isinstance X-Git-Tag: bind10-1.0.0-rc-release~25^2~13^2~2 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f7c0e1bf2a90711cd6df426b17465eedafaade00;p=thirdparty%2Fkea.git [2439] Add missing isinstance We check the result is of correct type, so use isinstance. It is unclear how the original code could pass, though. --- diff --git a/src/lib/python/isc/xfrin/tests/diff_tests.py b/src/lib/python/isc/xfrin/tests/diff_tests.py index 0b4b91f140..f013cd5a13 100644 --- a/src/lib/python/isc/xfrin/tests/diff_tests.py +++ b/src/lib/python/isc/xfrin/tests/diff_tests.py @@ -1128,7 +1128,7 @@ class DiffTest(unittest.TestCase): self.assertEqual(1, len(self.__data_operations)) self.assertEqual('add', self.__data_operations[0][0]) # Check the returned one is actually RRsetCollection - self.assertTrue(collection, self.Collection) + self.assertTrue(isinstance(collection, self.Collection)) # The collection is just the mock from above, so this doesn't do much # testing, but we check that the mock got through and didn't get hurt. self.assertIsNone(collection.find(Name('example.org'), RRClass.IN(),