From: Jonathan Cavitt Date: Tue, 16 Sep 2025 17:43:19 +0000 (+0000) Subject: drm/i915/gvt: Remove unnecessary check in reg_is_mmio X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f80fb921747b46d3e65887099977e457fba7256a;p=thirdparty%2Fkernel%2Flinux.git drm/i915/gvt: Remove unnecessary check in reg_is_mmio The reg >= 0 check in reg_is_mmio is unnecessary because reg is always greater than zero in all current use cases. This is obvious when checking 'offset' by itself (as offset is defined as an unsigned integer), but it's also true for the offset + bytes - 1 use case in intel_vgpu_emulate_mmio_read because bytes > 0. Signed-off-by: Jonathan Cavitt Reviewed-by: Andi Shyti Reviewed-by: Zhenyu Wang Signed-off-by: Andi Shyti Link: https://lore.kernel.org/r/20250916174317.76521-5-jonathan.cavitt@intel.com --- diff --git a/drivers/gpu/drm/i915/gvt/mmio.c b/drivers/gpu/drm/i915/gvt/mmio.c index da1135fa7cda4..c60d1e5488001 100644 --- a/drivers/gpu/drm/i915/gvt/mmio.c +++ b/drivers/gpu/drm/i915/gvt/mmio.c @@ -58,7 +58,7 @@ int intel_vgpu_gpa_to_mmio_offset(struct intel_vgpu *vgpu, u64 gpa) } #define reg_is_mmio(gvt, reg) \ - (reg >= 0 && reg < gvt->device_info.mmio_size) + (reg < gvt->device_info.mmio_size) #define reg_is_gtt(gvt, reg) \ (reg >= gvt->device_info.gtt_start_offset \