From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Sat, 31 May 2025 23:52:56 +0000 (-0600)
Subject: Yielded makes more sense than resumable
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f81d33d35c3b2b00428bca0ae06bcc4e8e5ea697;p=thirdparty%2Ffreeradius-server.git

Yielded makes more sense than resumable
---

diff --git a/src/lib/unlang/interpret.c b/src/lib/unlang/interpret.c
index 1237764b057..80378423954 100644
--- a/src/lib/unlang/interpret.c
+++ b/src/lib/unlang/interpret.c
@@ -194,7 +194,7 @@ static void frame_dump(request_t *request, unlang_stack_frame_t *frame)
 	RDEBUG2("scr_priority   %d", frame->scratch_result.priority);
 	RDEBUG2("top_frame      %s", is_top_frame(frame) ? "yes" : "no");
 	RDEBUG2("repeat         %s", is_repeatable(frame) ? "yes" : "no");
-	RDEBUG2("resumable      %s", is_yielded(frame) ? "yes" : "no");
+	RDEBUG2("yielded        %s", is_yielded(frame) ? "yes" : "no");
 	RDEBUG2("unwind         %s", is_unwinding(frame) ? "yes" : "no");
 
 	if (frame->instruction) {
@@ -1385,6 +1385,10 @@ void unlang_interpret_signal(request_t *request, fr_signal_t action)
 		 *	If the request was _not_ cancelled, it means
 		 *	it's not cancellable, and we need to let the
 		 *	request progress normally.
+		 *
+		 *	A concrete example of this, is the parent of
+		 *	subrequests, which must not continue until
+		 *	the subrequest is done.
 		 */
 		if (stack && is_yielded(frame) && is_unwinding(frame) && !unlang_request_is_scheduled(request)) {
 			unlang_interpret_mark_runnable(request);