From: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Date: Mon, 10 Oct 2022 22:14:31 +0000 (-0700)
Subject: gh-44098: Release the GIL during mmap on Unix (GH-98146)
X-Git-Tag: v3.12.0a1~136
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f871e9a7bb4eb823da481b99052636763ec8e710;p=thirdparty%2FPython%2Fcpython.git

gh-44098: Release the GIL during mmap on Unix (GH-98146)



This seems pretty straightforward. The issue mentions other calls in mmapmodule that we could release the GIL on, but those are in methods where we'd need to be careful to ensure that something sensible happens if those are called concurrently. In prior art, note that #12073 released the GIL for munmap.  In a toy benchmark, I see the speedup you'd expect from doing this.

Automerge-Triggered-By: GH:gvanrossum
---

diff --git a/Misc/NEWS.d/next/Library/2022-10-10-09-52-21.gh-issue-44098.okcqJt.rst b/Misc/NEWS.d/next/Library/2022-10-10-09-52-21.gh-issue-44098.okcqJt.rst
new file mode 100644
index 000000000000..4efea4a7c4fc
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2022-10-10-09-52-21.gh-issue-44098.okcqJt.rst
@@ -0,0 +1 @@
+Release the GIL when creating :class:`mmap.mmap` objects on Unix.
diff --git a/Modules/mmapmodule.c b/Modules/mmapmodule.c
index 5c05aa738ef5..fdce783fdec5 100644
--- a/Modules/mmapmodule.c
+++ b/Modules/mmapmodule.c
@@ -1318,9 +1318,9 @@ new_mmap_object(PyTypeObject *type, PyObject *args, PyObject *kwdict)
         }
     }
 
-    m_obj->data = mmap(NULL, map_size,
-                       prot, flags,
-                       fd, offset);
+    Py_BEGIN_ALLOW_THREADS
+    m_obj->data = mmap(NULL, map_size, prot, flags, fd, offset);
+    Py_END_ALLOW_THREADS
 
     if (devzero != -1) {
         close(devzero);