From: Alexey Izbyshev <izbyshev@ispras.ru>
Date: Wed, 22 Aug 2018 04:51:25 +0000 (+0300)
Subject: bpo-34456: pickle: Add missing NULL check to save_global(). (GH-8851)
X-Git-Tag: v3.8.0a1~1185
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f8c06b028036e50596e75d4c9f6b27ba05133efe;p=thirdparty%2FPython%2Fcpython.git

bpo-34456: pickle: Add missing NULL check to save_global(). (GH-8851)

Reported by Svace static analyzer.
---

diff --git a/Modules/_pickle.c b/Modules/_pickle.c
index ea778c763520..517c99e1746b 100644
--- a/Modules/_pickle.c
+++ b/Modules/_pickle.c
@@ -3454,6 +3454,8 @@ save_global(PicklerObject *self, PyObject *obj, PyObject *name)
             PickleState *st = _Pickle_GetGlobalState();
             PyObject *reduce_value = Py_BuildValue("(O(OO))",
                                         st->getattr, parent, lastname);
+            if (reduce_value == NULL)
+                goto error;
             status = save_reduce(self, reduce_value, NULL);
             Py_DECREF(reduce_value);
             if (status < 0)