From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Thu, 29 Jul 2021 15:44:42 +0000 (-0700)
Subject: bpo-44752: refactor part of rlcompleter.Completer.attr_matches (GH-27433) (GH-27447)
X-Git-Tag: v3.10.0rc1~35
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f8e13e35d12bee6e3447c791199522249ba7f05a;p=thirdparty%2FPython%2Fcpython.git

bpo-44752: refactor part of rlcompleter.Completer.attr_matches (GH-27433) (GH-27447)

(cherry picked from commit 6741794dd420c6b9775a188690dbf265037cd69f)

Co-authored-by: Jack DeVries <58614260+jdevries3133@users.noreply.github.com>
---

diff --git a/Lib/rlcompleter.py b/Lib/rlcompleter.py
index 34b259916e8e..98b7930b32fa 100644
--- a/Lib/rlcompleter.py
+++ b/Lib/rlcompleter.py
@@ -186,13 +186,10 @@ class Completer:
                         # property method, which is not desirable.
                         matches.append(match)
                         continue
-                    try:
-                        val = getattr(thisobject, word)
-                    except Exception:
-                        pass  # Include even if attribute not set
+                    if (value := getattr(thisobject, word, None)) is not None:
+                        matches.append(self._callable_postfix(value, match))
                     else:
-                        match = self._callable_postfix(val, match)
-                    matches.append(match)
+                        matches.append(match)
             if matches or not noprefix:
                 break
             if noprefix == '_':