From: Noel Power <noel.power@suse.com>
Date: Thu, 14 Jun 2018 14:32:03 +0000 (+0100)
Subject: python/samba: enclose map.values with list (py2/py3)
X-Git-Tag: tevent-0.9.37~254
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f8ecffb61a703ebb31ad5c985174c161b44434a4;p=thirdparty%2Fsamba.git

python/samba: enclose map.values with list (py2/py3)

Fix errors in samba.tests.samba_tool.visualize_drs that with python 3
will generate exception with messages something like
'can't iterate dict_values'

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/python/samba/graph.py b/python/samba/graph.py
index 6290ebeeb10..e80a8820667 100644
--- a/python/samba/graph.py
+++ b/python/samba/graph.py
@@ -84,7 +84,7 @@ def shorten_vertex_names(vertices, suffix=',...', aggressive=False):
         # walk backwards along all the strings until we meet a character
         # that is not shared by all.
         i = -1
-        vlist = vmap.values()
+        vlist = list(vmap.values())
         try:
             while True:
                 c = set(x[i] for x in vlist)