From: Lennart Poettering <lennart@poettering.net>
Date: Mon, 5 Sep 2022 13:14:11 +0000 (+0200)
Subject: homed: don't wait indefinitely for workers on exit
X-Git-Tag: v252-rc1~255^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f8f621821a30b5b7e6c69dfb770e1c4cbc3db715;p=thirdparty%2Fsystemd.git

homed: don't wait indefinitely for workers on exit

Let's put some time-limit on it.

Fixes: #22901
---

diff --git a/src/home/homed-home.c b/src/home/homed-home.c
index 8a389f72163..2b7c18d32f4 100644
--- a/src/home/homed-home.c
+++ b/src/home/homed-home.c
@@ -3149,13 +3149,21 @@ int home_set_current_message(Home *h, sd_bus_message *m) {
 }
 
 int home_wait_for_worker(Home *h) {
+        int r;
+
         assert(h);
 
         if (h->worker_pid <= 0)
                 return 0;
 
         log_info("Worker process for home %s is still running while exiting. Waiting for it to finish.", h->user_name);
-        (void) wait_for_terminate(h->worker_pid, NULL);
+
+        r = wait_for_terminate_with_timeout(h->worker_pid, 30 * USEC_PER_SEC);
+        if (r == -ETIMEDOUT)
+                log_warning_errno(r, "Waiting for worker process for home %s timed out. Ignoring.", h->user_name);
+        else
+                log_warning_errno(r, "Failed to wait for worker process for home %s. Ignoring.", h->user_name);
+
         (void) hashmap_remove_value(h->manager->homes_by_worker_pid, PID_TO_PTR(h->worker_pid), h);
         h->worker_pid = 0;
         return 1;