From: Richard Purdie Date: Sat, 15 Feb 2014 13:49:38 +0000 (+0000) Subject: runqueue: Fix silly variable overlap X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=f975ca2cf728561bd6317ed8f76303598546113a;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git runqueue: Fix silly variable overlap A previous commit of mine used the target variable for two different uses resulting in a lot more sstate being installed than is needed. Fix the variable to use two different names and unbreak the setscene behaviour. Signed-off-by: Richard Purdie --- diff --git a/lib/bb/runqueue.py b/lib/bb/runqueue.py index 15064f8142c..413d59f8f4f 100644 --- a/lib/bb/runqueue.py +++ b/lib/bb/runqueue.py @@ -1888,12 +1888,12 @@ class RunQueueExecuteScenequeue(RunQueueExecute): if nexttask not in self.unskippable and len(self.sq_revdeps[nexttask]) > 0 and self.sq_revdeps[nexttask].issubset(self.scenequeue_covered) and self.check_dependencies(nexttask, self.sq_revdeps[nexttask], True): realtask = self.rqdata.runq_setscene[nexttask] fn = self.rqdata.taskData.fn_index[self.rqdata.runq_fnid[realtask]] - target = False + foundtarget = False for target in self.rqdata.target_pairs: if target[0] == fn and target[1] == self.rqdata.runq_task[realtask]: - target = True + foundtarget = True break - if not target: + if not foundtarget: logger.debug(2, "Skipping setscene for task %s" % self.rqdata.get_user_idstring(self.rqdata.runq_setscene[nexttask])) self.task_skip(nexttask) self.scenequeue_notneeded.add(nexttask)