From: Gary Lockyer <gary@catalyst.net.nz>
Date: Thu, 30 Apr 2020 23:17:04 +0000 (+1200)
Subject: Fix clang 9 logical-not-parentheses warnings
X-Git-Tag: ldb-2.2.0~568
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fa8332780d2b0d31e92846fa7b1a45c130fa35c4;p=thirdparty%2Fsamba.git

Fix clang 9 logical-not-parentheses warnings

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/buildtools/wafsamba/samba_autoconf.py b/buildtools/wafsamba/samba_autoconf.py
index 5098648efd7..caa97b8e868 100644
--- a/buildtools/wafsamba/samba_autoconf.py
+++ b/buildtools/wafsamba/samba_autoconf.py
@@ -796,7 +796,6 @@ int main(void) {
             conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=missing-field-initializers', testflags=True)
             conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=unused-function', testflags=True)
             conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=enum-conversion', testflags=True)
-            conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=logical-not-parentheses', testflags=True)
             conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=constant-conversion', testflags=True)
 
     if Options.options.fatal_errors:
diff --git a/source4/torture/gpo/apply.c b/source4/torture/gpo/apply.c
index de5836d1a5f..c4a6499f4cc 100644
--- a/source4/torture/gpo/apply.c
+++ b/source4/torture/gpo/apply.c
@@ -61,7 +61,7 @@ static int exec_wait(struct torture_context *tctx, const char **gpo_update_cmd)
 	if (!tevent_req_poll_ntstatus(req, tctx->ev, &status)) {
 		return -1;
 	}
-	if (!samba_runcmd_recv(req, &ret) == 0) {
+	if (samba_runcmd_recv(req, &ret) != 0) {
 		return -1;
 	}
 	return ret;