From: Nicholas Nethercote <njn@valgrind.org>
Date: Mon, 4 Apr 2005 02:52:16 +0000 (+0000)
Subject: Remove the x86-specific is_valid_data_size() test.  Also, make any dataSize
X-Git-Tag: svn/VALGRIND_3_0_0~800
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fa9e1310ce560d376170609fe9b05ca1862cb6ff;p=thirdparty%2Fvalgrind.git

Remove the x86-specific is_valid_data_size() test.  Also, make any dataSize
greater than MIN_LINE_SIZE equal to MIN_LINE_SIZE.  This makes the
x86/fpu-28-108 regression test pass.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@3518
---

diff --git a/cachegrind/cg_main.c b/cachegrind/cg_main.c
index 1570c8f847..3173c7be62 100644
--- a/cachegrind/cg_main.c
+++ b/cachegrind/cg_main.c
@@ -493,13 +493,6 @@ void do_details( instr_info* n, Bool bbSeenBefore,
    }
 }
 
-// XXX: very x86-specific...
-static Bool is_valid_data_size(Int data_size)
-{
-   return (4 == data_size || 2  == data_size || 1 == data_size || 
-           8 == data_size || 10 == data_size || MIN_LINE_SIZE == data_size);
-}
-
 static Bool loadStoreAddrsMatch(IRExpr* loadAddrExpr, IRExpr* storeAddrExpr)
 {
   // I'm assuming that for 'modify' instructions, that Vex always makes
@@ -545,6 +538,11 @@ void endOfInstr(IRBB* bbOut, instr_info* i_node, Bool bbSeenBefore,
               (instrLen >= VGA_MIN_INSTR_SIZE && 
                instrLen <= VGA_MAX_INSTR_SIZE) );
 
+   // Large (eg. 28B, 108B, 512B on x86) data-sized instructions will be
+   // done inaccurately, but they're very rare and this avoids errors from
+   // hitting more than two cache lines in the simulation.
+   if (dataSize > MIN_LINE_SIZE) dataSize = MIN_LINE_SIZE;
+
    // Setup 1st arg: instr_info node's address
    // Believed to be 64-bit clean
    do_details(i_node, bbSeenBefore, instrAddr, instrLen, dataSize );
@@ -560,7 +558,6 @@ void endOfInstr(IRBB* bbOut, instr_info* i_node, Bool bbSeenBefore,
 
    } else if (loadAddrExpr && !storeAddrExpr) {
       // load
-      tl_assert( is_valid_data_size(dataSize) );
       tl_assert( isIRAtom(loadAddrExpr) );
       helperName = "log_1I_1Dr_cache_access";
       helperAddr = &log_1I_1Dr_cache_access;
@@ -570,7 +567,6 @@ void endOfInstr(IRBB* bbOut, instr_info* i_node, Bool bbSeenBefore,
 
    } else if (!loadAddrExpr && storeAddrExpr) {
       // store
-      tl_assert( is_valid_data_size(dataSize) );
       tl_assert( isIRAtom(storeAddrExpr) );
       helperName = "log_1I_1Dw_cache_access";
       helperAddr = &log_1I_1Dw_cache_access;
@@ -580,7 +576,6 @@ void endOfInstr(IRBB* bbOut, instr_info* i_node, Bool bbSeenBefore,
  
    } else {
       tl_assert( loadAddrExpr && storeAddrExpr );
-      tl_assert( is_valid_data_size(dataSize) );
       tl_assert( isIRAtom(loadAddrExpr) );
       tl_assert( isIRAtom(storeAddrExpr) );