From: Volker Lendecke <vl@samba.org>
Date: Wed, 25 Jul 2018 10:05:58 +0000 (+0200)
Subject: idmap: Make pointer initialization explicit
X-Git-Tag: ldb-1.5.0~168
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fa9e6a50da49bcab1da7533c72cee0687b4bb048;p=thirdparty%2Fsamba.git

idmap: Make pointer initialization explicit

Took me a few seconds to find this NULL initializer

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/winbindd/idmap_tdb_common.c b/source3/winbindd/idmap_tdb_common.c
index 48d87bb16cf..ceb663c0ddd 100644
--- a/source3/winbindd/idmap_tdb_common.c
+++ b/source3/winbindd/idmap_tdb_common.c
@@ -221,14 +221,13 @@ NTSTATUS idmap_tdb_common_set_mapping(struct idmap_domain * dom,
 	struct idmap_tdb_common_context *ctx;
 	struct idmap_tdb_common_set_mapping_context state;
 	NTSTATUS ret;
-	char *ksidstr, *kidstr;
+	char *ksidstr = NULL;
+	char *kidstr = NULL;
 
 	if (!map || !map->sid) {
 		return NT_STATUS_INVALID_PARAMETER;
 	}
 
-	ksidstr = kidstr = NULL;
-
 	/* TODO: should we filter a set_mapping using low/high filters ? */
 
 	ctx =