From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Date: Tue, 12 Oct 2021 07:18:43 +0000 (-0700) Subject: bpo-45401: Fix a resource warning in test_logging (GH-28864) (GH-28873) X-Git-Tag: v3.9.8~74 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=faa87f7f3b60f79b9018aaef0efa5e00d82b817b;p=thirdparty%2FPython%2Fcpython.git bpo-45401: Fix a resource warning in test_logging (GH-28864) (GH-28873) (cherry picked from commit 15188b115a2da815556053372c912a81a74be43b) Co-authored-by: Serhiy Storchaka --- diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py index 8202879df067..876c91f64eb7 100644 --- a/Lib/test/test_logging.py +++ b/Lib/test/test_logging.py @@ -5174,6 +5174,7 @@ class TimedRotatingFileHandlerTest(BaseFileTest): time.sleep(1.1) # a little over a second ... r = logging.makeLogRecord({'msg': 'testing - device file'}) self.assertFalse(fh.shouldRollover(r)) + fh.close() # other test methods added below def test_rollover(self):