From: Brian Norris Date: Sun, 23 Nov 2014 06:30:06 +0000 (-0800) Subject: views: patch-list: show the 'Properties' update box for all users X-Git-Tag: v1.1.0~197 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fac14d2b00bfa30892f9c7ce9eefc9c355caf04a;p=thirdparty%2Fpatchwork.git views: patch-list: show the 'Properties' update box for all users Any authenticated user should be able to change the properties of their own patches from the list view. They can already do so from the patch view and from pwclient. Now, authenticated users can perform 'Change state', 'Delegate to', and 'Archive' operations on multiple patches at a time (e.g., after 'select-all' on a bundle, or after selecting a few patches individually). We'll print an error message to the page for any patches which can't be updated (e.g., due to ownership). This fixes a usability issue that has been reported a few times. Signed-off-by: Brian Norris Acked-by: Stephen Finucane --- diff --git a/patchwork/views/__init__.py b/patchwork/views/__init__.py index 8df8920c..ffae91a1 100644 --- a/patchwork/views/__init__.py +++ b/patchwork/views/__init__.py @@ -56,7 +56,7 @@ def generic_list(request, project, view, data = None user = request.user properties_form = None - if project.is_editable(user): + if user.is_authenticated(): # we only pass the post data to the MultiplePatchForm if that was # the actual form submitted