From: Michael Adam <obnox@samba.org>
Date: Tue, 8 Jul 2008 13:33:36 +0000 (+0200)
Subject: tdbtool: fix off-by-one error in argument length. (bug #2344)
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fafb8ad2b81b9a46cf8259bedc1dca5023b06115;p=thirdparty%2Fsamba.git

tdbtool: fix off-by-one error in argument length. (bug #2344)

This prevented all commands operating on keys (all non-traverse commands)
in tdbtool to fail with a "fetch failed" or "delete failed" message.

It seems that it fixes bug #2344 ...

Apparently this bug was introduced with 94e53472666ed in 2005.
Either nobody is using tdbtool or else tdb_find() has become
more strict about the key legth in the meantime. :-)

Michael
---

diff --git a/source/lib/tdb/tools/tdbtool.c b/source/lib/tdb/tools/tdbtool.c
index d104ccd7c44..500e441c6a1 100644
--- a/source/lib/tdb/tools/tdbtool.c
+++ b/source/lib/tdb/tools/tdbtool.c
@@ -598,7 +598,7 @@ static char *convert_string(char *instring, size_t *sizep)
 	}
 	length++;
     }
-    *sizep = length;
+    *sizep = length + 1;
     return instring;
 }