From: Noel Power <noel.power@suse.com>
Date: Wed, 10 Jul 2019 10:41:29 +0000 (+0000)
Subject: libcli/smb: clang: Fix 'Dereference of null pointer'
X-Git-Tag: talloc-2.3.0~75
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fb49e411aa3ca397b19ea57528c2f67f9b85c877;p=thirdparty%2Fsamba.git

libcli/smb: clang: Fix 'Dereference of null pointer'

Fixes:

smbXcli_base.c:4885:20: warning: Dereference of null pointer <--[clang]
        body = (uint8_t *)iov[1].iov_base;
                          ^~~~~~~~~~~~~~~

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/libcli/smb/smbXcli_base.c b/libcli/smb/smbXcli_base.c
index b0e8aabb72e..0e45fd9836e 100644
--- a/libcli/smb/smbXcli_base.c
+++ b/libcli/smb/smbXcli_base.c
@@ -4851,7 +4851,7 @@ static void smbXcli_negprot_smb2_done(struct tevent_req *subreq)
 	size_t security_offset, security_length;
 	DATA_BLOB blob;
 	NTSTATUS status;
-	struct iovec *iov;
+	struct iovec *iov = NULL;
 	uint8_t *body;
 	size_t i;
 	uint16_t dialect_revision;
@@ -4879,7 +4879,7 @@ static void smbXcli_negprot_smb2_done(struct tevent_req *subreq)
 
 	status = smb2cli_req_recv(subreq, state, &iov,
 				  expected, ARRAY_SIZE(expected));
-	if (tevent_req_nterror(req, status)) {
+	if (tevent_req_nterror(req, status) || iov == NULL) {
 		return;
 	}