From: Emma Smith <emma@emmatyping.dev>
Date: Wed, 21 May 2025 19:09:34 +0000 (-0400)
Subject: gh-132983: Fix refleak in zstd dictionary functions (gh-134459)
X-Git-Tag: v3.15.0a1~1590
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fb68776591485cacd63a97a342bf294a6ae6d4e4;p=thirdparty%2FPython%2Fcpython.git

gh-132983: Fix refleak in zstd dictionary functions (gh-134459)
---

diff --git a/Modules/_zstd/_zstdmodule.c b/Modules/_zstd/_zstdmodule.c
index b2e4f95b9063..17d3bff1e987 100644
--- a/Modules/_zstd/_zstdmodule.c
+++ b/Modules/_zstd/_zstdmodule.c
@@ -251,7 +251,7 @@ _zstd_train_dict_impl(PyObject *module, PyBytesObject *samples_bytes,
                                             &chunk_sizes);
     if (chunks_number < 0)
     {
-        return NULL;
+        goto error;
     }
 
     /* Allocate dict buffer */
@@ -333,7 +333,7 @@ _zstd_finalize_dict_impl(PyObject *module, PyBytesObject *custom_dict_bytes,
                                             &chunk_sizes);
     if (chunks_number < 0)
     {
-        return NULL;
+        goto error;
     }
 
     /* Allocate dict buffer */