From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 24 Nov 2022 17:42:08 +0000 (+0100)
Subject: resolved: remove inappropriate assert()
X-Git-Tag: v253-rc1~451
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fb896517aeecc2a8ec16586a34a0249606eb9f66;p=thirdparty%2Fsystemd.git

resolved: remove inappropriate assert()

A NULL Bitmap object is by all our code considered identical to an empty
bitmap. Hence let's remove the entirely unnecessary assert().

The assert() can be triggered if debug monitoring is used an an empty
NSEC or NSEC3 RR is included in an answer resolved returns.

it's not really a security issue since enabling debug monitoring is a
manual step requiring root privileges, that is off by default. Moreover,
it's a "clean" assert(), i.e. the worst that happens is tha a coredump
is generated and resolved restarted.

Fixes: #25449
---

diff --git a/src/resolve/resolved-dns-rr.c b/src/resolve/resolved-dns-rr.c
index 8123ca1f98e..d47cdbbd8e2 100644
--- a/src/resolve/resolved-dns-rr.c
+++ b/src/resolve/resolved-dns-rr.c
@@ -1865,7 +1865,6 @@ static int type_bitmap_to_json(Bitmap *b, JsonVariant **ret) {
         unsigned t;
         int r;
 
-        assert(b);
         assert(ret);
 
         BITMAP_FOREACH(t, b) {