From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 23 Nov 2017 16:37:49 +0000 (+0100)
Subject: path-lookup: LookupPathsFlags are a flags type, hence define it like one
X-Git-Tag: v236~94^2~18
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fbc58835235f8a7a045be2831fe0a8d11f7d7bea;p=thirdparty%2Fsystemd.git

path-lookup: LookupPathsFlags are a flags type, hence define it like one

We shouldn't rely on C's incremental assignment of values of enums for
bit fields. That'll work only between the first two flags, but for
everything following will break horrible. Hence, let's avoid any
ambiguity here, and let's clearly define the flags as shifts of 1.
---

diff --git a/src/shared/path-lookup.h b/src/shared/path-lookup.h
index 8ea263e473b..bcf9ca4de6d 100644
--- a/src/shared/path-lookup.h
+++ b/src/shared/path-lookup.h
@@ -28,8 +28,8 @@ typedef struct LookupPaths LookupPaths;
 #include "macro.h"
 
 typedef enum LookupPathsFlags {
-        LOOKUP_PATHS_EXCLUDE_GENERATED = 1,
-        LOOKUP_PATHS_TEMPORARY_GENERATED,
+        LOOKUP_PATHS_EXCLUDE_GENERATED   = 1 << 0,
+        LOOKUP_PATHS_TEMPORARY_GENERATED = 1 << 1,
 } LookupPathsFlags;
 
 struct LookupPaths {