From: Ethan Furman Date: Wed, 16 Sep 2020 19:37:54 +0000 (-0700) Subject: _auto_called cleanup (GH-22285) X-Git-Tag: v3.10.0a1~102 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fc23a9483ef0d7c98bea9f82392377d0b6ef7b18;p=thirdparty%2FPython%2Fcpython.git _auto_called cleanup (GH-22285) --- diff --git a/Lib/enum.py b/Lib/enum.py index 060b2a0dadf4..21a94caaee33 100644 --- a/Lib/enum.py +++ b/Lib/enum.py @@ -105,9 +105,9 @@ class _EnumDict(dict): # enum overwriting a descriptor? raise TypeError('%r already defined as: %r' % (key, self[key])) if isinstance(value, auto): - self._auto_called = True if value.value == _auto_null: value.value = self._generate_next_value(key, 1, len(self._member_names), self._last_values[:]) + self._auto_called = True value = value.value self._member_names.append(key) self._last_values.append(value) diff --git a/Lib/test/test_enum.py b/Lib/test/test_enum.py index 5d72d82cec27..ebf76047972d 100644 --- a/Lib/test/test_enum.py +++ b/Lib/test/test_enum.py @@ -1837,6 +1837,17 @@ class TestEnum(unittest.TestCase): def _generate_next_value_(name, start, count, last): return name + def test_auto_order_wierd(self): + weird_auto = auto() + weird_auto.value = 'pathological case' + class Color(Enum): + red = weird_auto + def _generate_next_value_(name, start, count, last): + return name + blue = auto() + self.assertEqual(list(Color), [Color.red, Color.blue]) + self.assertEqual(Color.red.value, 'pathological case') + self.assertEqual(Color.blue.value, 'blue') def test_duplicate_auto(self): class Dupes(Enum):