From: Kirill Podoprigora <kirill.bast9@mail.ru>
Date: Wed, 22 Jan 2025 20:39:26 +0000 (+0200)
Subject: gh-129192: Use `EnvironmentVarGuard` to restore environment variables (#129193)
X-Git-Tag: v3.14.0a5~286
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fc6d4b71eb6bb4dcef3def286302e6bec37aec9f;p=thirdparty%2FPython%2Fcpython.git

gh-129192: Use `EnvironmentVarGuard` to restore environment variables (#129193)

Co-authored-by: Cody Maloney <cmaloney@theoreticalchaos.com>
---

diff --git a/Lib/test/test_zipfile/test_core.py b/Lib/test/test_zipfile/test_core.py
index ab5fb6500843..76b1de0e3519 100644
--- a/Lib/test/test_zipfile/test_core.py
+++ b/Lib/test/test_zipfile/test_core.py
@@ -1801,17 +1801,17 @@ class OtherTests(unittest.TestCase):
                     self.assertAlmostEqual(z_time, g_time, delta=1)
 
     def test_write_without_source_date_epoch(self):
-        if 'SOURCE_DATE_EPOCH' in os.environ:
-            del os.environ['SOURCE_DATE_EPOCH']
+        with os_helper.EnvironmentVarGuard() as env:
+            del env['SOURCE_DATE_EPOCH']
 
-        with zipfile.ZipFile(TESTFN, "w") as zf:
-            zf.writestr("test_no_source_date_epoch.txt", "Testing without SOURCE_DATE_EPOCH")
+            with zipfile.ZipFile(TESTFN, "w") as zf:
+                zf.writestr("test_no_source_date_epoch.txt", "Testing without SOURCE_DATE_EPOCH")
 
-        with zipfile.ZipFile(TESTFN, "r") as zf:
-            zip_info = zf.getinfo("test_no_source_date_epoch.txt")
-            current_time = time.localtime()[:6]
-            for z_time, c_time in zip(zip_info.date_time, current_time):
-                self.assertAlmostEqual(z_time, c_time, delta=1)
+            with zipfile.ZipFile(TESTFN, "r") as zf:
+                zip_info = zf.getinfo("test_no_source_date_epoch.txt")
+                current_time = time.localtime()[:6]
+                for z_time, c_time in zip(zip_info.date_time, current_time):
+                    self.assertAlmostEqual(z_time, c_time, delta=1)
 
     def test_close(self):
         """Check that the zipfile is closed after the 'with' block."""