From: Michal Nowak <mnowak@isc.org>
Date: Tue, 28 Jul 2026 14:57:47 +0000 (+0200)
Subject: Do not question obvious human Co-Authored-By trailers
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fc7dc9d882f6a73aa745859cf2ff571db6b7e34b;p=thirdparty%2Fbind9.git

Do not question obvious human Co-Authored-By trailers

Danger asks the reviewer to confirm that the person named in every
`Co-Authored-By` trailer is a human.  A trailer pointing at an
@isc.org address leaves no room for doubt, so stop emitting that
message for those and keep it for everything else.

Assisted-by: Claude:claude-opus-5[1m]
---

diff --git a/dangerfile.py b/dangerfile.py
index 72ccab00aa6..4a5cfd0f97f 100644
--- a/dangerfile.py
+++ b/dangerfile.py
@@ -182,6 +182,11 @@ LLM_SIGNED_OFF_BY_RE = re.compile(
     re.IGNORECASE | re.MULTILINE,
 )
 COAUTHORED_BY_RE = re.compile(r"^Co-Authored-By:.*$", re.IGNORECASE | re.MULTILINE)
+# A trailer pointing at an @isc.org address is a human co-author; there
+# is no point in asking for confirmation.
+HUMAN_COAUTHORED_BY_RE = re.compile(
+    r"^Co-Authored-By:\s+.*<[^<>@\s]+@isc\.org>$", re.IGNORECASE
+)
 # CONTRIBUTING.md documents the trailer format as
 # `Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]`.  Match every
 # `Assisted-by:` line, then check it against the expected shape.
@@ -242,6 +247,8 @@ for commit in danger.git.commits:
         )
     else:
         for coauthor_line in COAUTHORED_BY_RE.findall(commit.message):
+            if HUMAN_COAUTHORED_BY_RE.match(coauthor_line.strip()):
+                continue
             message(
                 f"Commit {commit.sha} contains a `Co-Authored-By` trailer: "
                 f"```{coauthor_line}```. Ensure the named co-author is a "