From: Stephen Morris Date: Fri, 7 Dec 2012 11:18:47 +0000 (+0000) Subject: [2404] Minor changes as a result of review X-Git-Tag: bind10-1.0.0-beta-release~39^2~5 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fca31329405278e34049e2e19982a82bc6fdf4f2;p=thirdparty%2Fkea.git [2404] Minor changes as a result of review --- diff --git a/src/lib/dhcp/duid.h b/src/lib/dhcp/duid.h index fe642f4dd2..1b75f73ebf 100644 --- a/src/lib/dhcp/duid.h +++ b/src/lib/dhcp/duid.h @@ -91,6 +91,11 @@ public: /// @brief Maximum size of a client ID /// /// This is the same as the maximum size of the underlying DUID. + /// + /// @note RFC 2131 does not specify an upper length of a client ID, the + /// value chosen here just being that of the underlying DUID. For + /// some backend database, there may be a possible (minor) + /// performance enhancement if this were smaller. static const size_t MAX_CLIENT_ID_LEN = DUID::MAX_DUID_LEN; /// @brief Constructor based on vector diff --git a/src/lib/dhcpsrv/mysql_lease_mgr.h b/src/lib/dhcpsrv/mysql_lease_mgr.h index be86c3a15f..8a97fc0773 100644 --- a/src/lib/dhcpsrv/mysql_lease_mgr.h +++ b/src/lib/dhcpsrv/mysql_lease_mgr.h @@ -110,7 +110,7 @@ public: /// @brief Returns an IPv4 lease for specified IPv4 address /// /// This method return a lease that is associated with a given address. - /// For other query types (by hardware addr, by DUID) there can be + /// For other query types (by hardware addr, by Client ID) there can be /// several leases in different subnets (e.g. for mobile clients that /// got address in different subnets). However, for a single address /// there can be only one lease, so this method returns a pointer to