From: Rafael J. Wysocki Date: Wed, 4 Mar 2026 18:15:21 +0000 (+0100) Subject: ACPI: TAD: Clear unused RT data in acpi_tad_set_real_time() X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fca4f233a247986db24b451682c3c6d52be4ff45;p=thirdparty%2Flinux.git ACPI: TAD: Clear unused RT data in acpi_tad_set_real_time() Move the clearing of the fields in struct acpi_tad_rt that are not used on the real time setting side to acpi_tad_set_real_time(). No intentional functional impact. Signed-off-by: Rafael J. Wysocki Link: https://patch.msgid.link/8660506.T7Z3S40VBb@rafael.j.wysocki --- diff --git a/drivers/acpi/acpi_tad.c b/drivers/acpi/acpi_tad.c index 240e5d53c4a5a..b570e1bda2361 100644 --- a/drivers/acpi/acpi_tad.c +++ b/drivers/acpi/acpi_tad.c @@ -96,6 +96,10 @@ static int acpi_tad_set_real_time(struct device *dev, struct acpi_tad_rt *rt) if (acpi_tad_rt_is_invalid(rt)) return -EINVAL; + rt->valid = 0; + rt->msec = 0; + memset(rt->padding, 0, 3); + args[0].buffer.pointer = (u8 *)rt; args[0].buffer.length = sizeof(*rt); @@ -233,10 +237,6 @@ static ssize_t time_store(struct device *dev, struct device_attribute *attr, rt.daylight = val; - rt.valid = 0; - rt.msec = 0; - memset(rt.padding, 0, 3); - ret = acpi_tad_set_real_time(dev, &rt); if (ret) return ret;