From: Lennart Poettering <lennart@poettering.net>
Date: Fri, 12 Oct 2018 16:38:40 +0000 (+0200)
Subject: json: fix memleak on OOM
X-Git-Tag: v240~556^2~8
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fcadf032c00f94a323fe0d15e45dd42b9765d979;p=thirdparty%2Fsystemd.git

json: fix memleak on OOM

CID 1396083
---

diff --git a/src/basic/json.c b/src/basic/json.c
index df3141fb2a5..426ed0328e2 100644
--- a/src/basic/json.c
+++ b/src/basic/json.c
@@ -2560,7 +2560,7 @@ int json_buildv(JsonVariant **ret, va_list ap) {
         };
 
         for (;;) {
-                JsonVariant *add = NULL;
+                _cleanup_(json_variant_unrefp) JsonVariant *add = NULL;
                 JsonStack *current;
                 int command;
 
@@ -2899,7 +2899,7 @@ int json_buildv(JsonVariant **ret, va_list ap) {
                                 goto finish;
                         }
 
-                        current->elements[current->n_elements++] = add;
+                        current->elements[current->n_elements++] = TAKE_PTR(add);
                 }
         }