From: Nikita Sobolev <mail@sobolevn.me>
Date: Wed, 13 Mar 2024 12:38:03 +0000 (+0300)
Subject: gh-116714: Handle errors correctly in `PyFloat_GetInfo` (#116715)
X-Git-Tag: v3.13.0a6~347
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fcd49b4f47f1edd9a2717f6619da7e7af8ea73cf;p=thirdparty%2FPython%2Fcpython.git

gh-116714: Handle errors correctly in `PyFloat_GetInfo` (#116715)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
---

diff --git a/Objects/floatobject.c b/Objects/floatobject.c
index 37d2d312a6a0..96227f2cf7d7 100644
--- a/Objects/floatobject.c
+++ b/Objects/floatobject.c
@@ -98,10 +98,18 @@ PyFloat_GetInfo(void)
         return NULL;
     }
 
-#define SetIntFlag(flag) \
-    PyStructSequence_SET_ITEM(floatinfo, pos++, PyLong_FromLong(flag))
-#define SetDblFlag(flag) \
-    PyStructSequence_SET_ITEM(floatinfo, pos++, PyFloat_FromDouble(flag))
+#define SetFlag(CALL) \
+    do {                                                    \
+        PyObject *flag = (CALL);                            \
+        if (flag == NULL) {                                 \
+            Py_CLEAR(floatinfo);                            \
+            return NULL;                                    \
+        }                                                   \
+        PyStructSequence_SET_ITEM(floatinfo, pos++, flag);  \
+    } while (0)
+
+#define SetIntFlag(FLAG) SetFlag(PyLong_FromLong((FLAG)))
+#define SetDblFlag(FLAG) SetFlag(PyFloat_FromDouble((FLAG)))
 
     SetDblFlag(DBL_MAX);
     SetIntFlag(DBL_MAX_EXP);
@@ -116,11 +124,8 @@ PyFloat_GetInfo(void)
     SetIntFlag(FLT_ROUNDS);
 #undef SetIntFlag
 #undef SetDblFlag
+#undef SetFlag
 
-    if (PyErr_Occurred()) {
-        Py_CLEAR(floatinfo);
-        return NULL;
-    }
     return floatinfo;
 }