From: Noel Power <noel.power@suse.com>
Date: Tue, 21 May 2019 10:48:18 +0000 (+0000)
Subject: lib/util: Fix cppcheck null pointer dereference warning
X-Git-Tag: ldb-2.0.5~573
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fd3f37af927cd926431a5dbd8f966d8c8e772dae;p=thirdparty%2Fsamba.git

lib/util: Fix cppcheck null pointer dereference warning

lib/util/talloc_report.c:58: warning: nullPointer: Possible null pointer dereference: start <--[cppcheck]

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/lib/util/talloc_report.c b/lib/util/talloc_report.c
index bed0fd91e43..fb12a2f631c 100644
--- a/lib/util/talloc_report.c
+++ b/lib/util/talloc_report.c
@@ -52,6 +52,8 @@ static char *talloc_vasprintf_append_largebuf(char *buf, ssize_t *pstr_len,
 	if (buflen > str_len) {
 		start = buf + str_len;
 		space = buflen - str_len;
+	} else {
+		return NULL;
 	}
 
 	va_copy(ap2, ap);