From: Andreas Schneider <asn@samba.org>
Date: Thu, 9 May 2019 14:18:51 +0000 (+0200)
Subject: s3:smbspool: Fix regression printing with Kerberos credentials
X-Git-Tag: tdb-1.4.1~146
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fd4b1f4f16aee3e3c9a2cb449655edfed171963a;p=thirdparty%2Fsamba.git

s3:smbspool: Fix regression printing with Kerberos credentials

This is a regression which has been introduced with Samba 4.8.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13939

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu May  9 16:46:05 UTC 2019 on sn-devel-184
---

diff --git a/source3/client/smbspool.c b/source3/client/smbspool.c
index 5efaa091913..22071613677 100644
--- a/source3/client/smbspool.c
+++ b/source3/client/smbspool.c
@@ -664,7 +664,7 @@ smb_connect(const char *workgroup,	/* I - Workgroup */
 	 * behavior with 3.0.14a
 	 */
 
-	if (username != NULL && username[0] != '\0') {
+	if (username == NULL || username[0] == '\0') {
 		if (kerberos_ccache_is_valid()) {
 			goto kerberos_auth;
 		}