From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Tue, 30 May 2023 09:53:46 +0000 (-0700)
Subject: [3.12] gh-102251: Fix reference leak in _testsinglephase initialization (GH-105082... 
X-Git-Tag: v3.12.0b2~53
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fd6b913535d78d3bfec710075ac930474c1057ca;p=thirdparty%2FPython%2Fcpython.git

[3.12] gh-102251: Fix reference leak in _testsinglephase initialization (GH-105082) (#105083)

Correctly decref 'initialized' in init_module()

(cherry picked from commit d14eb3433cf2a40a202471b815f0a935f2840ead)

Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
---

diff --git a/Modules/_testsinglephase.c b/Modules/_testsinglephase.c
index a16157702ae7..8e6973f0b052 100644
--- a/Modules/_testsinglephase.c
+++ b/Modules/_testsinglephase.c
@@ -140,7 +140,9 @@ init_module(PyObject *module, module_state *state)
     if (initialized == NULL) {
         return -1;
     }
-    if (PyModule_AddObjectRef(module, "_module_initialized", initialized) != 0) {
+    int rc = PyModule_AddObjectRef(module, "_module_initialized", initialized);
+    Py_DECREF(initialized);
+    if (rc < 0) {
         return -1;
     }