From: Ralph Boehme Date: Fri, 25 Oct 2024 15:22:57 +0000 (+0200) Subject: smbd: fix sharing access check for directories X-Git-Tag: tdb-1.4.13~839 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fdd133ae650d13cb457f7e7529f3bb6df47d8cee;p=thirdparty%2Fsamba.git smbd: fix sharing access check for directories This was missing from commit 6140c3177a0330f42411618c3fca28930ea02a21 and causes all opens of directories to be handled as stat opens, bypassing the sharemode check. Not adding a test at this time, as my (hopefully) soon to be merged Directory Leases branch has a test which actually detected this problem. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15732 Signed-off-by: Ralph Boehme Reviewed-by: Stefan Metzmacher Autobuild-User(master): Ralph Böhme Autobuild-Date(master): Tue Oct 29 12:44:49 UTC 2024 on atb-devel-224 --- diff --git a/source3/smbd/open.c b/source3/smbd/open.c index 0d05bd953c0..351b8f8e33e 100644 --- a/source3/smbd/open.c +++ b/source3/smbd/open.c @@ -5447,6 +5447,7 @@ static NTSTATUS open_directory(connection_struct *conn, .req = req, .create_disposition = create_disposition, .access_mask = access_mask, + .open_access_mask = access_mask, .share_access = share_access, .oplock_request = NO_OPLOCK, .lease = NULL,