From: Daniel Stenberg <daniel@haxx.se>
Date: Thu, 27 Jun 2024 06:48:18 +0000 (+0200)
Subject: conncache: done always evaluates to false
X-Git-Tag: curl-8_9_0~174
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fde2143df75f5ded02a3e5392e828dd5a6a9dfd0;p=thirdparty%2Fcurl.git

conncache: done always evaluates to false

Follow-up to c9b95c0bb30f88bf00e1ac

Spotted by CodeSonar

Reviewed-by: Stefan Eissing
Closes #14034
---

diff --git a/lib/conncache.c b/lib/conncache.c
index 95042abe42..4024a715ce 100644
--- a/lib/conncache.c
+++ b/lib/conncache.c
@@ -690,7 +690,7 @@ static void connc_discard_conn(struct conncache *connc,
    * not what we want. */
   if(aborted)
     done = TRUE;
-  else if(!done) {
+  if(!done) {
     /* Attempt to shutdown the connection right away. */
     Curl_attach_connection(data, conn);
     connc_run_conn_shutdown(data, conn, &done);