From: Steve Dower <steve.dower@python.org>
Date: Wed, 11 Mar 2020 14:12:31 +0000 (+0000)
Subject: bpo-39930: Convert error to warning for more silent failure (GH-18921)
X-Git-Tag: v3.9.0a5~102
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fde44ae6d08d3df79554155b1cf079e73a8fabdd;p=thirdparty%2FPython%2Fcpython.git

bpo-39930: Convert error to warning for more silent failure (GH-18921)

Makes it an error to create a layout without vcruntime DLL
---

diff --git a/PC/layout/main.py b/PC/layout/main.py
index 305cb517d0f7..3eef7556299c 100644
--- a/PC/layout/main.py
+++ b/PC/layout/main.py
@@ -173,8 +173,12 @@ def get_layout(ns):
     if ns.include_stable:
         yield from in_build(PYTHON_STABLE_DLL_NAME)
 
+    found_any = False
     for dest, src in rglob(ns.build, "vcruntime*.dll"):
+        found_any = True
         yield dest, src
+    if not found_any:
+        log_error("Failed to locate vcruntime DLL in the build.")
 
     yield "LICENSE.txt", ns.build / "LICENSE.txt"
 
diff --git a/PCbuild/pyproject.props b/PCbuild/pyproject.props
index 0bbdcfa1dbf5..061c2253bcf0 100644
--- a/PCbuild/pyproject.props
+++ b/PCbuild/pyproject.props
@@ -217,7 +217,7 @@ public override bool Execute() {
       <VCRuntimeDLL Include="$(VCRedistDir)\Microsoft.VC*.CRT\vcruntime*.dll" />
     </ItemGroup>
 
-    <Error Text="vcruntime14*.dll not found under $(VCInstallDir)" Condition="@(VCRuntimeDLL) == ''" />
+    <Warning Text="vcruntime14*.dll not found under $(VCInstallDir)" Condition="@(VCRuntimeDLL) == ''" />
     <Message Text="VCRuntimeDLL: @(VCRuntimeDLL)" Importance="high" />
   </Target>
 </Project>