From: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Date: Fri, 2 Aug 2024 22:56:51 +0000 (+0100)
Subject: gh-122560: add test that comprehension loop var appears only in one scope of the... 
X-Git-Tag: v3.14.0a1~899
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fe0a28d850943cf2ba132c9b0a933bb0c98ff0ae;p=thirdparty%2FPython%2Fcpython.git

gh-122560: add test that comprehension loop var appears only in one scope of the symtable (#122582)
---

diff --git a/Lib/test/test_symtable.py b/Lib/test/test_symtable.py
index bd367c1591c7..24d89b09d946 100644
--- a/Lib/test/test_symtable.py
+++ b/Lib/test/test_symtable.py
@@ -528,6 +528,27 @@ class SymtableTest(unittest.TestCase):
         self.assertEqual(repr(self.top._table), expected)
 
 
+class ComprehensionTests(unittest.TestCase):
+    def get_identifiers_recursive(self, st, res):
+        res.extend(st.get_identifiers())
+        for ch in st.get_children():
+            self.get_identifiers_recursive(ch, res)
+
+    def test_loopvar_in_only_one_scope(self):
+        # ensure that the loop variable appears only once in the symtable
+        comps = [
+            "[x for x in [1]]",
+            "{x for x in [1]}",
+            "{x:x*x for x in [1]}",
+        ]
+        for comp in comps:
+            with self.subTest(comp=comp):
+                st = symtable.symtable(comp, "?", "exec")
+                ids = []
+                self.get_identifiers_recursive(st, ids)
+                self.assertEqual(len([x for x in ids if x == 'x']), 1)
+
+
 class CommandLineTest(unittest.TestCase):
     maxDiff = None