From: Stefan Metzmacher Date: Thu, 7 May 2020 10:04:00 +0000 (+0200) Subject: interface: clarify the quoting for advanced "interfaces" options X-Git-Tag: ldb-2.2.0~630 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fe3380d369c2a528f89da5a047235420cec63b4d;p=thirdparty%2Fsamba.git interface: clarify the quoting for advanced "interfaces" options Signed-off-by: Stefan Metzmacher Reviewed-by: Ralph Boehme --- diff --git a/source3/lib/interface.c b/source3/lib/interface.c index 55fa8534976..35cfc5eee62 100644 --- a/source3/lib/interface.c +++ b/source3/lib/interface.c @@ -419,7 +419,11 @@ static void parse_extra_info(char *key, uint64_t *speed, uint32_t *cap, Additional information for an interface can be specified with this extended syntax: - interface[;key1=value1[,key2=value2[...]]] + "interface[;key1=value1[,key2=value2[...]]]" + + Note: The double quoting is important for the + smb.conf parser! Otherwise the ';' and ',' separates + two interfaces. where - keys known: 'speed', 'capability', 'if_index' @@ -429,6 +433,8 @@ static void parse_extra_info(char *key, uint64_t *speed, uint32_t *cap, these indexes should not conicide with indexes the kernel sets... + Note: The specified values overwrite the autodetected values! + ****************************************************************************/ static void interpret_interface(char *token)