From: JINMEI Tatuya <jinmei@isc.org>
Date: Sat, 22 Dec 2012 19:00:40 +0000 (-0800)
Subject: [2480] avoid redundant text dump of RRSIGs in pullSigs().
X-Git-Tag: bind10-1.0.0-rc-release~95^2~22^2~11^2~14
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fe40dade09da3ca910f034e650db2a3d5a93a49b;p=thirdparty%2Fkea.git

[2480] avoid redundant text dump of RRSIGs in pullSigs().

now that RRset::toText() includes RRSIGs, the additional toText() is not
necessary; in fact, that would lead to confusing output from failed tests.
---

diff --git a/src/lib/testutils/dnsmessage_test.h b/src/lib/testutils/dnsmessage_test.h
index 262d1778fe..6de01ec86a 100644
--- a/src/lib/testutils/dnsmessage_test.h
+++ b/src/lib/testutils/dnsmessage_test.h
@@ -208,10 +208,9 @@ pullSigs(std::vector<isc::dns::ConstRRsetPtr>& rrsets,
 {
     for (ITERATOR it = begin; it != end; ++it) {
         rrsets.push_back(*it);
-        text += (*it)->toText();
+        text += (*it)->toText(); // this will include RRSIG, if attached.
         if ((*it)->getRRsig()) {
             rrsets.push_back((*it)->getRRsig());
-            text += (*it)->getRRsig()->toText();
         }
     }
 }